Skip to content

Commit

Permalink
Rely on refresh context to update stats independently of overview cards.
Browse files Browse the repository at this point in the history
  • Loading branch information
justinkambic committed Oct 17, 2022
1 parent 4234417 commit 4975273
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,13 @@ import { EuiFlexGroup, EuiFlexItem, EuiPanel, EuiSpacer, EuiStat, EuiTitle } fro
import { i18n } from '@kbn/i18n';
import React, { useEffect } from 'react';
import { useDispatch, useSelector } from 'react-redux';
import { clearOverviewStatusErrorAction, selectOverviewStatus } from '../../../../state';
import {
clearOverviewStatusErrorAction,
fetchOverviewStatusAction,
selectOverviewStatus,
} from '../../../../state';
import { kibanaService } from '../../../../../../utils/kibana_service';
import { useSyntheticsRefreshContext } from '../../../../contexts';

function title(t?: number) {
return t ?? '-';
Expand All @@ -20,6 +25,12 @@ export function OverviewStatus() {
const { status, statusError } = useSelector(selectOverviewStatus);
const dispatch = useDispatch();

const { lastRefresh } = useSyntheticsRefreshContext();

useEffect(() => {
dispatch(fetchOverviewStatusAction.get());
}, [dispatch, lastRefresh]);

useEffect(() => {
if (statusError) {
dispatch(clearOverviewStatusErrorAction());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { useEnablement } from '../../../hooks';
import { useSyntheticsRefreshContext } from '../../../contexts/synthetics_refresh_context';
import {
fetchMonitorOverviewAction,
fetchOverviewStatusAction,
selectOverviewState,
selectServiceLocationsState,
} from '../../../state';
Expand Down Expand Up @@ -53,7 +52,6 @@ export const OverviewPage: React.FC = () => {

useEffect(() => {
dispatch(fetchMonitorOverviewAction.get(pageState));
dispatch(fetchOverviewStatusAction.get());
}, [dispatch, pageState]);

const {
Expand Down

0 comments on commit 4975273

Please sign in to comment.