Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Security Solution][Investigations] - Remove DataProvider from bottom bar #140727

Merged
merged 5 commits into from
Sep 16, 2022
Merged

[Bug][Security Solution][Investigations] - Remove DataProvider from bottom bar #140727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46555d7
remove dataproviders from bottom bar
michaelolo24 Sep 14, 2022
aef1cc8
remove unused dataprovider tests
michaelolo24 Sep 14, 2022
be85678
cleanup code
michaelolo24 Sep 14, 2022
c6e732f
fix tests
michaelolo24 Sep 15, 2022
b4c4cf1
rename boolean
michaelolo24 Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
283 changes: 1 addition & 282 deletions ...ns/security_solution/public/timelines/components/flyout/__snapshots__/index.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 3 additions & 58 deletions ...ck/plugins/security_solution/public/timelines/components/flyout/bottom_bar/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,91 +9,36 @@ import React from 'react';
import { render, screen } from '@testing-library/react';

import { TestProviders } from '../../../../common/mock/test_providers';
import { TimelineTabs } from '../../../../../common/types/timeline';
import { FlyoutBottomBar } from '.';

describe('FlyoutBottomBar', () => {
test('it renders the expected bottom bar', () => {
render(
<TestProviders>
<FlyoutBottomBar
timelineId="test"
showDataproviders={true}
activeTab={TimelineTabs.query}
/>
<FlyoutBottomBar timelineId="test" showTimelineHeaderPanel={true} />
</TestProviders>
);

expect(screen.getByTestId('flyoutBottomBar')).toBeInTheDocument();
});

test('it renders the data providers drop target area', () => {
render(
<TestProviders>
<FlyoutBottomBar
timelineId="test"
showDataproviders={true}
activeTab={TimelineTabs.query}
/>
</TestProviders>
);

expect(screen.getByTestId('dataProviders')).toBeInTheDocument();
});

test('it renders the flyout header panel', () => {
render(
<TestProviders>
<FlyoutBottomBar
timelineId="test"
showDataproviders={true}
activeTab={TimelineTabs.query}
/>
<FlyoutBottomBar timelineId="test" showTimelineHeaderPanel={true} />
</TestProviders>
);

expect(screen.getByTestId('timeline-flyout-header-panel')).toBeInTheDocument();
});

test('it hides the data providers drop target area', () => {
render(
<TestProviders>
<FlyoutBottomBar
timelineId="test"
showDataproviders={false}
activeTab={TimelineTabs.query}
/>
</TestProviders>
);

expect(screen.queryByTestId('dataProviders')).not.toBeInTheDocument();
});

test('it hides the flyout header panel', () => {
render(
<TestProviders>
<FlyoutBottomBar
timelineId="test"
showDataproviders={false}
activeTab={TimelineTabs.query}
/>
<FlyoutBottomBar timelineId="test" showTimelineHeaderPanel={false} />
</TestProviders>
);

expect(screen.queryByTestId('timeline-flyout-header-panel')).not.toBeInTheDocument();
});

test('it renders the data providers drop target area when showDataproviders=false and tab is not query', () => {
render(
<TestProviders>
<FlyoutBottomBar
timelineId="test"
showDataproviders={false}
activeTab={TimelineTabs.notes}
/>
</TestProviders>
);

expect(screen.getByTestId('dataProviders')).toBeInTheDocument();
});
});
Loading