[Bug][Security Solution][Investigations] - Remove DataProvider from bottom bar #140727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolo24
added
bug
michaelolo24
force-pushed
the
fix-timeline-bug
branch
from
253f953
to
b4c4cf1
Compare
andrew-goldstein
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Thanks for this fix @michaelolo24! 🙏
Desk tested locally in
- Chrome
105.0.5195.102 - Firefox
104.0.2 - Safari
16.0
LGTM 🚀
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a bug after this change #139524 which caused the data providers in the timeline bottom bar to always be visible. Since the data provider is not being used anymore after drag and drop was removed outside of timeline, it's no longer necessary. This PR removes the data provider from the bottom bar.
Original issue: #140247