Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Discover locator (#102712) #103072

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[7.x] Discover locator (#102712) #103072

merged 1 commit into from
Jun 23, 2021

Conversation

streamich
Copy link
Contributor

Backports the following commits to 7.x:

* Add Discover locator

* Add Discover locator tests

* Expose locator for Discover app and deprecate URL generator

* Use Discover locator in Explore Underlying Data

* Fix explore data unit tests after refactor

* fix: 🐛 update Discover plugin mock

* style: 💄 remove any

* test: 💍 fix test mock

* fix: 🐛 adjust property name after refactor

* test: 💍 fix tests after refactor

Co-authored-by: Vadim Kibana <vadimkibana@gmail.com>
@streamich streamich enabled auto-merge (squash) June 23, 2021 11:31
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 375 376 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 52 55 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 86.3KB 88.3KB +2.0KB
discoverEnhanced 9.1KB 8.9KB -289.0B
total +1.7KB
Unknown metric groups

API count

id before after diff
discover 65 81 +16

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 9e2b89d into elastic:7.x Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants