Discover locator

[streamich]

Summary

Partially addresses #98107

• Deprecates Discover URL generator
• Adds Discover locator
• Switches "Explore Underlying Data" actions to use Discover locator

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServices)

[Dosant]

Tested Explore underlying data from dashboard to discover and Discover search session which still uses old URL generator.

[kertal]

Code LGTM, KibanaApp owned code review, checked out, tested explore underlying data, works as expected. One question, would it be possible to use this generator in our functional tests?

[streamich]

@kertal It is our plan to remove the URL generator in one of the subsequent PRs, so it is better not to use it in any tests; but use locator instead. With regards to functional tests specifically, the functional tests don't know what is used under the hood. So for example "explore underlying data" functional tests just pass.

[kertal]

@kertal It is our plan to remove the URL generator in one of the subsequent PRs, so it is better not to use it in any tests; but use locator instead. With regards to functional tests specifically, the functional tests don't know what is used under the hood. So for example "explore underlying data" functional tests just pass.

I'm aware of this, my question was more, could we use the functionality of the locator to generate links in our functional tests? often the UI is used for defining time ranges necessary for certain tests. doing it directly with a generated URL would be faster

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 036333b
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
discover	375	376	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
discover	52	55	+3
share	78	81	+3
total			+6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
discover	86.3KB	88.3KB	+2.0KB
discoverEnhanced	9.1KB	8.9KB	-289.0B
share	73.8KB	74.8KB	+1.0KB
total			+2.8KB

Unknown metric groups

API count

id	before	after	diff
discover	65	81	+16
share	102	119	+17
total			+33

History

• 💚 Build #133145 succeeded fc4ee8e
• 💔 Build #133130 failed db08b69
• 💔 Build #132651 failed 33c643b
• 💔 Build #132602 failed 862ff0b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[streamich]

@kertal That's a good questions. I'm not sure. Currently canonically you would consume locator through a plugin contract, but to use it in a functional test we would need to load it somehow differently (or expose a back door for functional tests to use plugin contracts). Maybe part of the locator that generates the link, for some locators, could be extracted into a separate file, and then functional tests could import that file.