Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Enable TSDB by default #7214

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Aug 2, 2023

What does this PR do?

Enable TSDB by default for all metrics data streams, except for:

  • Endpoint security metrics: it never receives any data.
  • Filebeat input metrics: the migration is failing with
    Error: error running package asset tests: could not complete test run: can't install the package: can't install the package: could not install package; API status code = 500; response body = {"statusCode":500,"error":"Internal Server Error","message":"invalid_index_template_exception\n\tRoot causes:\n\t\tinvalid_index_template_exception: index_template [metrics-elastic_agent.filebeat_input] invalid, cause [Validation Failed: 1: [index.mode=time_series] requires a non-empty [index.routing_path];]"}
    
    However, agent.id is set as dimension and it is always present for all documents. I cannot find the reason for why this is happening, so I am removing this data stream migration from this PR.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6938.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m added Team:Elastic-Agent Label for the Agent team Integration:elastic_agent Elastic Agent labels Aug 2, 2023
@constanca-m constanca-m self-assigned this Aug 2, 2023
@constanca-m constanca-m requested a review from a team as a code owner August 2, 2023 09:06
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Aug 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-08T07:13:17.200+0000

  • Duration: 15 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 2, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.392
Classes 100.0% (0/0) 💚 3.392
Methods 33.333% (25/75) 👎 -58.484
Lines 100.0% (0/0) 💚 11.755
Conditionals 100.0% (0/0) 💚

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Copy link
Contributor

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m merged commit 277d6b6 into elastic:main Aug 8, 2023
1 check passed
@constanca-m constanca-m deleted the elastic-agent-enable-tsdb branch August 8, 2023 13:19
@elasticmachine
Copy link

Package elastic_agent - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Enable TSDB by default.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
carsonip added a commit that referenced this pull request Jul 10, 2024
[elastic_agent] Add back apm-server monitoring metrics dropped due to TSDB

* apm-server metrics were dropped due to TSDB change in #7214
* output field depends on beats#40127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:elastic_agent Elastic Agent Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants