Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elastic_agent] Add back apm-server metrics dropped due to TSDB #10414

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jul 8, 2024

Proposed commit message

[elastic_agent] Add back apm-server monitoring metrics dropped due to TSDB

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  • Spin up local elastic-package stack with changes
  • Start EA with agent monitoring enabled
  • Add APM to EA
  • Confirm that apm-server monitoring metric fields are stored

Related issues

Part of elastic/apm-server#13475

Screenshots

@carsonip carsonip added bug Something isn't working, use only for issues bugfix Pull request that fixes a bug issue and removed bug Something isn't working, use only for issues labels Jul 8, 2024
@carsonip carsonip changed the title [elastic_agent] Add apm server metrics fields [elastic_agent] Add back apm-server metrics dropped due to TSDB Jul 9, 2024
@carsonip carsonip marked this pull request as ready for review July 9, 2024 14:31
@carsonip carsonip requested a review from a team as a code owner July 9, 2024 14:31
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] label Jul 9, 2024
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@carsonip carsonip marked this pull request as draft July 9, 2024 15:10
@carsonip carsonip marked this pull request as ready for review July 9, 2024 16:42
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

@carsonip carsonip merged commit 6b5b935 into elastic:main Jul 10, 2024
4 of 5 checks passed
@elasticmachine
Copy link

Package elastic_agent - 2.0.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:elastic_agent Elastic Agent Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants