Add nio Buffers to Painless #79870
Merged
Add nio Buffers to Painless #79870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Oct 26, 2021
| int limit() | ||
| } | ||
|
|
||
| class java.nio.ByteBuffer { |
There was a problem hiding this comment.
Should we also expose the wrap methods? Otherwise null would be the only value available to pass to getValue on a binary field?
| IntBuffer asIntBuffer() | ||
| LongBuffer asLongBuffer() | ||
| ShortBuffer asShortBuffer() | ||
| byte get(int) |
There was a problem hiding this comment.
I think we also need order, otherwise the order is always big endian. I think is ok to have a such a setter because it modifies the byte buffer object, which is transient, not the underlying data.
There was a problem hiding this comment.
I'll add this too.
|
@rjernst I've added the requested methods along with tests. |
|
@rjernst Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the basic java.nio.Buffer to Painless along with the typed direct subclasses. We have only allow listed an absolute get method and some conversion methods to ensure that we do not limit our design space moving forward without more discussion. This includes a test for each method added.
This supports (#79760).
I have also added an issue to allow list the rest of the absolute getter methods (#79867) once Java 13+ is available.