Add BinaryDocValuesField to replace BytesRef (ScriptDocValues) #79760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
49 tasks
stu-elastic
reviewed
Oct 25, 2021
...g-painless/src/main/resources/org/elasticsearch/painless/org.elasticsearch.script.fields.txt
Outdated
Show resolved
Hide resolved
stu-elastic
reviewed
Oct 25, 2021
...g-painless/src/main/resources/org/elasticsearch/painless/org.elasticsearch.script.fields.txt
Outdated
Show resolved
Hide resolved
stu-elastic
reviewed
Oct 25, 2021
server/src/main/java/org/elasticsearch/index/fielddata/ScriptDocValues.java
Outdated
Show resolved
Hide resolved
|
@stu-elastic Thanks for solid feedback. Switched this over to byte[] and added utility to get these at utf8 to String. |
rjernst
reviewed
Oct 26, 2021
...g-painless/src/main/resources/org/elasticsearch/painless/org.elasticsearch.script.fields.txt
Outdated
Show resolved
Hide resolved
...g-painless/src/main/resources/org/elasticsearch/painless/org.elasticsearch.script.fields.txt
Outdated
Show resolved
Hide resolved
|
@stu-elastic @rjernst This is ready for another round of review. |
rjernst
approved these changes
Oct 27, 2021
...g-painless/src/main/resources/org/elasticsearch/painless/org.elasticsearch.script.fields.txt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/field/BinaryDocValuesField.java
Show resolved
Hide resolved
stu-elastic
reviewed
Oct 27, 2021
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpProcessor.java
Outdated
Show resolved
Hide resolved
stu-elastic
reviewed
Oct 27, 2021
server/src/main/java/org/elasticsearch/script/field/DelegateDocValuesField.java
Outdated
Show resolved
Hide resolved
stu-elastic
reviewed
Oct 27, 2021
...toring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/ClusterAlertsUtilTests.java
Outdated
Show resolved
Hide resolved
stu-elastic
approved these changes
Oct 27, 2021
stu-elastic
reviewed
Oct 28, 2021
...gned-long/src/main/java/org/elasticsearch/xpack/unsignedlong/UnsignedLongDocValuesField.java
Show resolved
Hide resolved
stu-elastic
reviewed
Oct 28, 2021
server/src/main/java/org/elasticsearch/index/fielddata/ScriptDocValues.java
Show resolved
Hide resolved
stu-elastic
reviewed
Oct 28, 2021
server/src/main/java/org/elasticsearch/script/field/BinaryDocValuesField.java
Outdated
Show resolved
Hide resolved
|
After discussion with @stu-elastic we're going to change the API a bit. We have decided to move the initial API to the following methods: getValue(default) -> get(default) This means users won't be able to get a List directly anymore, but instead can treat Field as an iterator. This decisions removes ambiguity over copied values and whether or not the List changes the Field that it was generate from. |
|
@stu-elastic Made the previously described changes. Would appreciate you looking them over one more time please. |
stu-elastic
reviewed
Oct 29, 2021
server/src/main/java/org/elasticsearch/script/field/DelegateDocValuesField.java
Show resolved
Hide resolved
stu-elastic
reviewed
Oct 29, 2021
stu-elastic
reviewed
Oct 29, 2021
...nless/src/yamlRestTest/resources/rest-api-spec/test/painless/60_script_doc_values_binary.yml
Show resolved
Hide resolved
stu-elastic
reviewed
Oct 29, 2021
...ang-painless/src/yamlRestTest/resources/rest-api-spec/test/painless/50_script_doc_values.yml
Show resolved
Hide resolved
|
Added getters for EmptyField along w/ tests. |
|
@stu-elastic @rjernst Thanks for the many reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates the classes required for the scripting fields API to provide a binary field composed of doc values using BytesRef as the representation returned to the user as a value.