-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Remove _term
and _time
agg order keys
#78209
[DOCS] Remove _term
and _time
agg order keys
#78209
Conversation
Adds an 8.0 breaking change for the removal of the `_term` and `_time` agg `order` keys. Relates to #39450
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Should we (do we?) support this in 7.x REST compatibility mode? IIRC that didn't exist when we dropped these sort keys |
I think we probably should, yeah. I think the docs change is still right even so. |
Thanks for calling this out @not-napoleon. It looks like we do support them with version compatibility headers. However, I don't think we need to call that out in this breaking change. IMO that's sorta the same as using a previous version of the API. elasticsearch/server/src/main/java/org/elasticsearch/search/aggregations/InternalOrder.java Line 579 in 979f297
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry, docs change is fine. I think we just need to also do REST compatibility.
Nice! I'd assumed we dumped them. I'm so happy we still have that. Now I can GC |
Adds an 8.0 breaking change for the removal of the
_term
and_time
agg
order
keys.Relates to #39450
Preview
https://elasticsearch_78209.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/migrating-8.0.html#breaking_80_aggregations_changes