Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated _time and _term sort orders #39450

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

polyfractal
Copy link
Contributor

Deprecated in 6.0, time to go :)

This isn't really a bugfix so I feel like we missed the boat on 7.0? Just target 8.0?

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @polyfractal

@polyfractal
Copy link
Contributor Author

Thanks @mayya-sharipova!

We decided to just remove in 8.0, since the code change is minimal and essentially zero maintenance burden.

@polyfractal polyfractal merged commit cec666b into elastic:master Mar 5, 2019
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jul 5, 2021
Previously removed in elastic#39450, deprecated in es6 but not removed in es 7.
defaults to _key behaviour

relates elastic#51816
pgomulka added a commit that referenced this pull request Jul 6, 2021
Previously removed in #39450, deprecated in es6 but not removed in es 7.
defaults to _key behaviour

relates #51816
jrodewig added a commit that referenced this pull request Sep 22, 2021
Adds an 8.0 breaking change for the removal of the `_term` and `_time`
agg `order` keys.

Relates to #39450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants