Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testCancelFailedSearchWhenPartialResultDisallowed #64248

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 27, 2020

The search request in the test can complete before the "cancelledLatch" is latched if the second shard request is sent after the request was canceled (i.e., the child task is not allowed to start after the parent was canceled).

Closes #63976
Relates ##63520

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.11.0 labels Oct 27, 2020
@dnhatn dnhatn requested a review from jimczi October 27, 2020 20:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Oct 27, 2020
@dnhatn
Copy link
Member Author

dnhatn commented Oct 27, 2020

run elasticsearch-ci/default-distro

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn merged commit 5a76944 into elastic:master Oct 28, 2020
@dnhatn dnhatn deleted the fix-testCancelFailedSearchWhenPartialResultDisallowed branch October 28, 2020 14:23
dnhatn added a commit that referenced this pull request Nov 10, 2020
The search request in the test can complete before the "cancelledLatch" 
is latched if the second shard request is sent after the request was
canceled (i.e., the child task is not allowed to start after the parent
was canceled).

Closes #63976
Relates ##63520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchCancellationIT#testCancelFailedSearchWhenPartialResultDisallowed fails
4 participants