Cancel search on shard failure when partial results disallowed #63520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
jimczi
reviewed
Oct 14, 2020
server/src/main/java/org/elasticsearch/action/search/SearchTransportService.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/action/search/CanMatchPreFilterSearchPhaseTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/AbstractSearchAsyncAction.java
Outdated
Show resolved
Hide resolved
|
run elasticsearch-ci/2 |
|
Thanks Jim! |
This was referenced Oct 27, 2020
dnhatn
added a commit
that referenced
this pull request
Nov 10, 2020
If the partial results parameter is false (which defaults to true), then we should cancel the search request when it hits a shard failure because the caller won't consume the partial results. Closes #60278
jtibshirani
added a commit
that referenced
this pull request
Nov 24, 2020
In #63520, we started cancelling searches that encounter shard failures and don't allow partial results. In this case we return an 'all shards failed' response, since there are no successful responses. This PR proposes to return a 'partial shards failure' instead. The reasoning: it's misleading to claim that 'all shards failed' when we only know at least one shard failed (and preemptively cancelled the rest).
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Nov 24, 2020
In elastic#63520, we started cancelling searches that encounter shard failures and don't allow partial results. In this case we return an 'all shards failed' response, since there are no successful responses. This PR proposes to return a 'partial shards failure' instead. The reasoning: it's misleading to claim that 'all shards failed' when we only know at least one shard failed (and preemptively cancelled the rest).
jtibshirani
added a commit
that referenced
this pull request
Nov 24, 2020
In #63520, we started cancelling searches that encounter shard failures and don't allow partial results. In this case we return an 'all shards failed' response, since there are no successful responses. This PR proposes to return a 'partial shards failure' instead. The reasoning: it's misleading to claim that 'all shards failed' when we only know at least one shard failed (and preemptively cancelled the rest).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the partial results parameter is false (which defaults to true), then we should cancel the search request when it hits a shard failure because the caller won't consume the partial results.
Closes #60278