Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print id detail when id is too long. #49433

Merged
merged 3 commits into from
Nov 24, 2019
Merged

print id detail when id is too long. #49433

merged 3 commits into from
Nov 24, 2019

Conversation

JaredTan95
Copy link
Contributor

Print id detail whenid is too long for easy debug.

@cbuescher cbuescher added the :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label Nov 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/CRUD)

dnhatn
dnhatn reviewed Nov 22, 2019
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. I left a minor suggestion. Can you also add a unit test for this change? Thank you.

server/src/main/java/org/elasticsearch/action/index/IndexRequest.java Show resolved Hide resolved
@dnhatn dnhatn added the v7.6.0 label Nov 22, 2019
@dnhatn
Copy link
Member

dnhatn commented Nov 24, 2019

@elasticmachine ok to test

@dnhatn
Copy link
Member

dnhatn commented Nov 24, 2019

@elasticmachine update branch

dnhatn
dnhatn approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @JaredTan95.

@dnhatn dnhatn merged commit 1140ebf into elastic:master Nov 24, 2019
@dnhatn dnhatn self-assigned this Nov 24, 2019
dnhatn pushed a commit that referenced this pull request Nov 24, 2019
@JaredTan95 @dnhatn
Include id to the error msg when it's too long (#49433)
1d2bfd1
@JaredTan95 JaredTan95 deleted the id_too_long branch November 25, 2019 00:06
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees

@dnhatn dnhatn

Labels
:Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >enhancement v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JaredTan95 @elasticmachine @dnhatn @jakelandis @cbuescher