Include id to the error msg when it's too long (#49433)

elastic · Nov 24, 2019 · 1d2bfd1 · 1d2bfd1
1 parent 777f6d5
commit 1d2bfd1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/server/src/main/java/org/elasticsearch/action/index/IndexRequest.java b/server/src/main/java/org/elasticsearch/action/index/IndexRequest.java
@@ -242,7 +242,7 @@ public ActionRequestValidationException validate() {
         validationException = DocWriteRequest.validateSeqNoBasedCASParams(this, validationException);
 
         if (id != null && id.getBytes(StandardCharsets.UTF_8).length > 512) {
-            validationException = addValidationError("id is too long, must be no longer than 512 bytes but was: " +
+            validationException = addValidationError("id [" + id + "] is too long, must be no longer than 512 bytes but was: " +
                             id.getBytes(StandardCharsets.UTF_8).length, validationException);
         }
 

diff --git a/server/src/test/java/org/elasticsearch/action/index/IndexRequestTests.java b/server/src/test/java/org/elasticsearch/action/index/IndexRequestTests.java
@@ -102,7 +102,7 @@ public void testIndexingRejectsLongIds() {
         validate = request.validate();
         assertThat(validate, notNullValue());
         assertThat(validate.getMessage(),
-                containsString("id is too long, must be no longer than 512 bytes but was: 513"));
+                containsString("id [" + id + "] is too long, must be no longer than 512 bytes but was: 513"));
     }
 
     public void testWaitForActiveShards() {