[ML] Wait for job updates in AutoDetectResultProcessor.awaitCompletion #36856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
>test
|
Pinging @elastic/ml-core |
davidkyle
changed the title
davidkyle
commented
Dec 19, 2018
| jobResultsProvider.getEstablishedMemoryUsage(jobId, latestBucketTimestamp, modelSizeStatsForCalc, establishedModelMemory -> { | ||
| if (latestEstablishedModelMemory != establishedModelMemory) { | ||
|
|
||
|
|
||
| client.threadPool().executor(MachineLearning.UTILITY_THREAD_POOL_NAME).submit(() -> { |
There was a problem hiding this comment.
Can submit() throw? I'm not sure if it is necessary to wrap this in a try...catch and release the semaphore in the catch
There was a problem hiding this comment.
Yes, it can throw rejected execution exception if the thread pool’s queue is full or it is shutting down.
There was a problem hiding this comment.
Also, it can use execute() rather than submit() as it's not interested in getting a Future to track completion. Since you're off I'll push another commit that changes both things.
Also use execute() rather than submit() when scheduling update
droberts195
pushed a commit
that referenced
this pull request
Dec 20, 2018
#36856) There was a race where the job update in `AutoDetectResultProcessor.updateEstablishedModelMemoryOnJob` could execute after `AutoDetectResultProcessor.awaitCompletion` returned. This was because ` jobUpdateSemaphore` was acquired after the call to `jobResultsProvider.getEstablishedMemoryUsage` and during that call `awaitCompletion` is free to acquire and release the semaphore after which the method returns. This commit fixes the problem. Closes #36849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race where the job update in
AutoDetectResultProcessor.updateEstablishedModelMemoryOnJobmay execute afterAutoDetectResultProcessor.awaitCompletionreturns. This was becausejobUpdateSemaphorewas acquired after the call tojobResultsProvider.getEstablishedMemoryUsageand during that callawaitCompletionis free to acquire and release the semaphore after which the method returns.Closes #36849