[ML] Set type on index requests in 6.x #36850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to elastic#36796 that is only required for 6.x. The type must be specified in the index request. This is not necessary in 7.x, hence the functionality works in the master build.
|
Pinging @elastic/ml-core |
|
Marked as |
|
run gradle build tests 2 |
|
It seems that the changes of #36856 need to be merged into this PR before it will pass CI |
|
run default distro tests |
|
run gradle build tests 1 |
|
run default distro tests |
|
run gradle build tests 1 |
benwtrent
approved these changes
Dec 20, 2018
|
run gradle build tests 1 |
droberts195
added a commit
that referenced
this pull request
Dec 20, 2018
This is a followup to #36796 that is only required for 6.x. The type must be specified in the index request. This is not necessary in 7.x, hence the functionality works in the master build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #36796 that is only required
for 6.x. The type must be specified in the index
request. This is not necessary in 7.x, hence the
functionality works in the master build.