Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ML put trained model API spec #2168

Closed

Conversation

droberts195
Copy link
Contributor

Built in models like ELSER do not require an inference_config be specified. #2098 adjusted the spec to reflect this in one place, but not in the put trained model API spec. This PR completes the change.

Built in models like ELSER do not require an inference_config be
specified. elastic#2098 adjusted the spec to reflect this in one place,
but not in the put trained model API spec. This PR completes the
change.
@droberts195 droberts195 requested review from a team as code owners July 5, 2023 13:01
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195
Copy link
Contributor Author

CI won't run on forks - will open a new PR.

@droberts195 droberts195 closed this Jul 5, 2023
@droberts195 droberts195 deleted the fix_put_trained_model_spec branch July 5, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants