-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text expansion config for the NLP APIs #2098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
changed the title
Add text expansion config
Add text expansion config for the NLP APIs
Apr 27, 2023
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
sethmlarson
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks @sethmlarson |
droberts195
added a commit
to droberts195/elasticsearch-specification
that referenced
this pull request
Jul 5, 2023
Built in models like ELSER do not require an inference_config be specified. elastic#2098 adjusted the spec to reflect this in one place, but not in the put trained model API spec. This PR completes the change.
droberts195
added a commit
that referenced
this pull request
Jul 5, 2023
Built in models like ELSER do not require an inference_config be specified. #2098 adjusted the spec to reflect this in one place, but not in the put trained model API spec. This PR completes the change.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
Built in models like ELSER do not require an inference_config be specified. #2098 adjusted the spec to reflect this in one place, but not in the put trained model API spec. This PR completes the change.
Anaethelion
pushed a commit
that referenced
this pull request
Jul 5, 2023
Built in models like ELSER do not require an inference_config be specified. #2098 adjusted the spec to reflect this in one place, but not in the put trained model API spec. This PR completes the change. Co-authored-by: David Roberts <dave.roberts@elastic.co>
swallez
pushed a commit
that referenced
this pull request
Jul 5, 2023
Built in models like ELSER do not require an inference_config be specified. #2098 adjusted the spec to reflect this in one place, but not in the put trained model API spec. This PR completes the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ML NLP APIs for new features added in 8.8. Namely the
text_expansion
config and adding the newdeployment_id
field to stats results.