Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error measuring embedding size for some DPR models #573

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Error measuring embedding size for some DPR models #573

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d3c5aab
The tuple may contain a single element
davidkyle Jul 31, 2023
6e88f35
review comments
davidkyle Aug 1, 2023
805c4ad
Merge branch 'main' into te-trace
davidkyle Aug 1, 2023
d1b179f
Merge branch 'main' into te-trace
davidkyle Aug 31, 2023
f53a7bd
Merge branch 'main' into te-trace
davidkyle Sep 5, 2023
4d28992
Merge branch 'main' into te-trace
davidkyle Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eland/ml/pytorch/transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ def _create_config(
else:
sample_embedding = self._traceable_model.sample_output()
if type(sample_embedding) is tuple:
text_embedding, _ = sample_embedding
text_embedding, *_ = sample_embedding
Copy link
Member

@joshdevins joshdevins Aug 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but it's maybe obscure Python code. We don't actually need to unpack the whole tuple, so it might make it clearer to just extract the first element, which is what we actually care about:

text_embedding = sample_embedding[0]

else:
text_embedding = sample_embedding

Expand Down