Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error measuring embedding size for some DPR models #573

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

davidkyle
Copy link
Member

@davidkyle davidkyle commented Aug 1, 2023

Installing the ance-dpr-context-multi model with the eland_import_hub_model script fails.

eland_import_hub_model       
    --url 'http://localhost:9200'             
    --hub-model-id 'ance-dpr-context-multi'
    --task-type text_embedding 

The error is due to unpacking a tuple that contains a single element.

python3.10/site-packages/eland/ml/pytorch/transformers.py", line 735, in _create_config
    text_embedding, _ = sample_embedding
ValueError: not enough values to unpack (expected 2, got 1)

The fix is to only take the first element

@davidkyle davidkyle added bug Something isn't working topic:NLP Issue or PR about NLP model support and eland_import_hub_model labels Aug 1, 2023
@@ -732,7 +732,7 @@ def _create_config(
else:
sample_embedding = self._traceable_model.sample_output()
if type(sample_embedding) is tuple:
text_embedding, _ = sample_embedding
text_embedding, *_ = sample_embedding
Copy link
Member

@joshdevins joshdevins Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but it's maybe obscure Python code. We don't actually need to unpack the whole tuple, so it might make it clearer to just extract the first element, which is what we actually care about:

text_embedding = sample_embedding[0]

@davidkyle
Copy link
Member Author

buildkite test this

@davidkyle davidkyle merged commit 301cda8 into elastic:main Sep 19, 2023
2 checks passed
@davidkyle davidkyle deleted the te-trace branch September 19, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic:NLP Issue or PR about NLP model support and eland_import_hub_model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants