This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
chore: rename ELASTIC_AGENT_USE_CI_SNAPSHOTS #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 2 |
| Passed | 82 |
| Skipped | 8 |
| Total | 92 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / Pre-Submit / Sanity checks / go vet – pre_commit.lint - Name:
Initializing / Pre-Submit / Sanity checks / golangcilint – pre_commit.lint
v1v
approved these changes
Jan 7, 2021
cachedout
approved these changes
Jan 7, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 7, 2021
* chore: rename variable to a wider scope * chore: extract common logic to a function * chore: rename variable # Conflicts: # .ci/Jenkinsfile # e2e/_suites/metricbeat/README.md
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 7, 2021
* chore: rename variable to a wider scope * chore: extract common logic to a function * chore: rename variable # Conflicts: # .ci/Jenkinsfile # e2e/_suites/metricbeat/README.md
mdelapenya
added a commit
that referenced
this pull request
Jan 7, 2021
…version before switching to the configuration file (#565) backport for 7.x (#568) * chore: rename ELASTIC_AGENT_USE_CI_SNAPSHOTS (#566) * chore: rename variable to a wider scope * chore: extract common logic to a function * chore: rename variable # Conflicts: # .ci/Jenkinsfile # e2e/_suites/metricbeat/README.md * fix: set image version before switching to the configuration file (#565) We still need to download the proper config file from the PR, but we do not have access to the commit SHA at this moment, unless other moddifications are in place, like reading from Jenkins
mdelapenya
added a commit
that referenced
this pull request
Jan 7, 2021
…version before switching to the configuration file (#565) backport for 7.10.x (#569) * chore: rename ELASTIC_AGENT_USE_CI_SNAPSHOTS (#566) * chore: rename variable to a wider scope * chore: extract common logic to a function * chore: rename variable # Conflicts: # .ci/Jenkinsfile # e2e/_suites/metricbeat/README.md * fix: set image version before switching to the configuration file (#565) We still need to download the proper config file from the PR, but we do not have access to the commit SHA at this moment, unless other moddifications are in place, like reading from Jenkins
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It renames the ELASTIC_AGENT_USE_CI_SNAPSHOTS to USE_CI_SNAPSHOTS, which makes its scope wider, and easier to reuse across different test suites.
It also includes a small refactor in the logic to get the Docker namespace: if we use CI snapshots, let's use
observability-ci, otherwise usebeats.Why is it important?
We consume that variable in both metricbeat and elastic-agent test suites, so we prefer clarity when using it.
Checklist
make noticein the proper directory)How to test this?
Related issues
Follow-ups
We must merge a PR in Beats with the update, as I could not find a simple way of not breaking the downstream project (Beats) after this change
Needs backport to 7.x and 7.10.x