This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
fix: set image version before switching to the configuration file #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still need to download the proper config file from the PR, but we do not have access to the commit SHA at this moment, unless other moddifications are in place, like reading from Jenkins
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 3 |
| Passed | 80 |
| Skipped | 9 |
| Total | 92 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / fleet_fleet_mode_agent / Un-installing the installed centos agent – Fleet Mode Agent - Name:
Initializing / Pre-Submit / Sanity checks / go vet – pre_commit.lint - Name:
Initializing / Pre-Submit / Sanity checks / golangcilint – pre_commit.lint
v1v
approved these changes
Jan 7, 2021
cachedout
approved these changes
Jan 7, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 7, 2021
…astic#565) We still need to download the proper config file from the PR, but we do not have access to the commit SHA at this moment, unless other moddifications are in place, like reading from Jenkins
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 7, 2021
…astic#565) We still need to download the proper config file from the PR, but we do not have access to the commit SHA at this moment, unless other moddifications are in place, like reading from Jenkins
mdelapenya
added a commit
that referenced
this pull request
Jan 7, 2021
…version before switching to the configuration file (#565) backport for 7.x (#568) * chore: rename ELASTIC_AGENT_USE_CI_SNAPSHOTS (#566) * chore: rename variable to a wider scope * chore: extract common logic to a function * chore: rename variable # Conflicts: # .ci/Jenkinsfile # e2e/_suites/metricbeat/README.md * fix: set image version before switching to the configuration file (#565) We still need to download the proper config file from the PR, but we do not have access to the commit SHA at this moment, unless other moddifications are in place, like reading from Jenkins
mdelapenya
added a commit
that referenced
this pull request
Jan 7, 2021
…version before switching to the configuration file (#565) backport for 7.10.x (#569) * chore: rename ELASTIC_AGENT_USE_CI_SNAPSHOTS (#566) * chore: rename variable to a wider scope * chore: extract common logic to a function * chore: rename variable # Conflicts: # .ci/Jenkinsfile # e2e/_suites/metricbeat/README.md * fix: set image version before switching to the configuration file (#565) We still need to download the proper config file from the PR, but we do not have access to the commit SHA at this moment, unless other moddifications are in place, like reading from Jenkins
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It switches the order of two operations: 1) setting the version for Metricbeat's docker image, and 2) defining which branch/tag will be used to download the configuration file.
Why is it important?
It causes a bug in the tests for metricbeat configuration in the case it's triggered by a PR from Beats: it will use the CI snapshots but the version, as it starts with
pr-, was replaced with the base version for the maintenance branch, when we still want to use the version of the PR (in the form of its Docker image, downloaded fromobservability-ciregistry)Checklist
make noticein the proper directory)How to test this PR locally
Related issues
Follow-ups
We still need to download the proper config file from the PR, but we do not have access to the commit SHA at this moment, unless other modifications are in place, like reading the SHA from Jenkins.