Add a new role for APM Server 8.7.0+ #6605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new role for APM Server 8.7.0+, adding read privileges for the system indices .apm-agent-configuration and .apm-source-map.
It's not a blocker. There are two features that this affects. Those features previously required a |
That's good to hear. @thbkrkr I think we should still aim to include this given that we have a bit more time. |
Yes, I think so too. I merge and take care of the backport. |
thbkrkr
changed the title
thbkrkr
approved these changes
Mar 28, 2023
thbkrkr
pushed a commit
to thbkrkr/cloud-on-k8s
that referenced
this pull request
Mar 28, 2023
Add a new role for APM Server 8.7.0+, adding read privileges for the system indices `.apm-agent-configuration` and `.apm-source-map`. This change is essentially to allow features that previously required a kibanaRef to work without a connection to Kibana.
thbkrkr
added a commit
that referenced
this pull request
Mar 28, 2023
Add a new role for APM Server 8.7.0+, adding read privileges for the system indices `.apm-agent-configuration` and `.apm-source-map`. This change is essentially to allow features that previously required a kibanaRef to work without a connection to Kibana. Co-authored-by: Andrew Wilkins <axwalk@gmail.com>
thbkrkr
added a commit
that referenced
this pull request
Apr 25, 2023
This adds a script that helps identifying changes that have been labeled as belonging to certain release version where the corresponding commits are not in the release branch. Its main purpose is to discover missing backports.
Testing:
- Success:
```sh
> hack/release-notes/check-release-notes.sh v2.7.0
Compare 'merged PR from 2.6.1 to v2.7.0' with 'release-notes/v2.7.0'
✅ LGTM
```
- Failure:
Simulate an invalid generated release note by deleting an entry:
```diff
diff --git a/docs/release-notes/2.7.0.asciidoc b/docs/release-notes/2.7.0.asciidoc
index 1518c41e6..ba3580da8 100644
--- a/docs/release-notes/2.7.0.asciidoc
+++ b/docs/release-notes/2.7.0.asciidoc
@@ -11,7 +11,6 @@
[float]
=== Enhancements
-* Add a new role for APM Server 8.7.0+ {pull}6605[#6605]
+* Add a new role for APM Server 8.7.0+ {pull}16605[#6605]
```
```sh
> hack/release-notes/check-release-notes.sh v2.7.0
Compare 'merged PR from 2.6.1 to v2.7.0' with 'release-notes/v2.7.0'
❌ Error: no commit found for the following issues:
> #16605
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new role for APM Server 8.7.0+, adding read privileges for the system indices
.apm-agent-configurationand.apm-source-map.