Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to check generated release notes #6723

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Apr 24, 2023

This adds a script that helps identifying changes that have been labeled as belonging to certain release version where the corresponding commits are not in the release branch. Its main purpose is to discover missing backports.

Testing:

  • Success:
> hack/release-notes/check-release-notes.sh v2.7.0
Compare 'merged PR from 2.6.1 to v2.7.0' with 'release-notes/v2.7.0'
✅ LGTM
  • Failure:

Simulate an invalid generated release note by deleting an entry:

diff --git a/docs/release-notes/2.7.0.asciidoc b/docs/release-notes/2.7.0.asciidoc
index 1518c41e6..ba3580da8 100644
--- a/docs/release-notes/2.7.0.asciidoc
+++ b/docs/release-notes/2.7.0.asciidoc
@@ -11,7 +11,6 @@
 [float]
 === Enhancements

-* Add a new role for APM Server 8.7.0+ {pull}6605[#6605]
+* Add a new role for APM Server 8.7.0+ {pull}16605[#6605]

> hack/release-notes/check-release-notes.sh v2.7.0
Compare 'merged PR from 2.6.1 to v2.7.0' with 'release-notes/v2.7.0'
❌ Error: no commit found for the following issues:
> #16605

@thbkrkr thbkrkr added >enhancement Enhancement of existing functionality :ci Things related to Continuous Integration, automation and releases labels Apr 24, 2023
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙇

hack/release-notes/check.sh Outdated Show resolved Hide resolved
hack/release-notes/check.sh Show resolved Hide resolved
@thbkrkr
Copy link
Contributor Author

thbkrkr commented Apr 25, 2023

buildkite test this

@thbkrkr thbkrkr added the v2.8.0 label Apr 25, 2023
@thbkrkr thbkrkr merged commit c3d84bf into elastic:main Apr 25, 2023
@thbkrkr thbkrkr deleted the add-check-release-notes branch May 10, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ci Things related to Continuous Integration, automation and releases >enhancement Enhancement of existing functionality v2.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants