-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "Operator crashes on startup with OOMKilled
" docs section
#5836
Conversation
Recommend setting `spec.containers[].resources.limits.memory` and `spec.containers[].resources.requests.memory` to the same value as a best practice. @kunisen
Adding example containerStatuses section for an OOMKilled event.
For the JVM it is indeed a best practice because:
Therefore, memory pages of an Elasticsearch Pod are immediately mapped, up to the The situation is a bit different for the operator since it is not running in a virtual machine, with a fixed amount of memory mapped. There may be memory usage spikes, but memory may eventually be returned to the operating system. Hence, having different values might make sense. That being said, we can indeed remind the user that to avoid any disruption it is recommend to:
|
Co-authored-by: Michael Morello <michael.morello@elastic.co>
Co-authored-by: Michael Morello <michael.morello@elastic.co>
thx for the suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor editing suggestion. Otherwise LGTM.
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
OOMKilled
" docs section
Add an example of an OOMKilled event that crashes the operator and share best practice on setting memory requests and limits to the same value. Co-authored-by: Michael Morello <michael.morello@elastic.co> Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com> Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
Add an example of an OOMKilled event and share best practice on setting memory limits: recommend setting
spec.containers[].resources.limits.memory
andspec.containers[].resources.requests.memory
to the same value.cc: @kunisen