Skip to content

Commit

Permalink
Update common-problems.asciidoc
Browse files Browse the repository at this point in the history 
Recommend setting `spec.containers[].resources.limits.memory` and `spec.containers[].resources.requests.memory` to the same value as a best practice.

@kunisen
  • Loading branch information
@ppf2
ppf2 committed Jun 28, 2022
1 parent 8df5d6c commit 842bbca
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions docs/operating-eck/troubleshooting/common-problems.asciidoc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ The default link:https://kubernetes.io/docs/concepts/configuration/manage-resour
kubectl patch sts elastic-operator -n elastic-system -p '{"spec":{"template":{"spec":{"containers":[{"name":"manager", "resources":{"limits":{"memory":"2Gi"}}}]}}}}'
----

NOTE: It is a best practice to set `spec.containers[].resources.limits.memory` and `spec.containers[].resources.requests.memory` to the same value.

[id="{p}-{page_id}-webhook-timeout"]
== Timeout when submitting a resource manifest
Expand Down

1 comment on commit 842bbca

@kunisen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ppf2 for the filing!
We also have this k8s best practice documented in our ECK doc below:
https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-managing-compute-resources.html

But I actually don't see it's defined in the example request kubectl patch sts elastic-operator -n elastic-system -p '{"spec":{"template":{"spec":{"containers":[{"name":"manager", "resources":{"limits":{"memory":"2Gi"}}}]}}}}'.
May I ask your opinion to see if we should also explicitly set that for the operator too, please? @pebrc

Please sign in to comment.