Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick to 7.9: fix: mark flaky tests (#21300) #22008

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Cherry-pick to 7.9: fix: mark flaky tests (#21300) #22008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c7bc5c
fix: mark flaky tests (#21300)
kuisathaverat Sep 30, 2020
a5dad14
Apply suggestions from code review
kuisathaverat Oct 20, 2020
57dd7e9
fix: skip python tests too
kuisathaverat Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions auditbeat/module/file_integrity/eventreader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func init() {
const ErrorSharingViolation syscall.Errno = 32

func TestEventReader(t *testing.T) {
t.Skip("Flaky test: about 1/10 of bulds fails https://github.com/elastic/beats/issues/21302")
// Make dir to monitor.
dir, err := ioutil.TempDir("", "audit")
if err != nil {
Expand Down Expand Up @@ -240,6 +241,7 @@ func TestEventReader(t *testing.T) {
}

func TestRaces(t *testing.T) {
t.Skip("Flaky test: about 1/20 of bulds fails https://github.com/elastic/beats/issues/21303")
const (
fileMode os.FileMode = 0640
N = 100
Expand Down
2 changes: 2 additions & 0 deletions filebeat/tests/system/test_reload_inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import os
import time
import unittest
from filebeat import BaseTest


Expand Down Expand Up @@ -249,6 +250,7 @@ def test_load_configs(self):
assert output[0]["message"] == first_line
assert output[1]["message"] == second_line

@unittest.skip("1/20 build fails https://github.com/elastic/beats/issues/21307")
def test_reload_same_config(self):
kuisathaverat marked this conversation as resolved.
Show resolved Hide resolved
"""
Test reload same config with same file but different config. Makes sure reloading also works on conflicts.
Expand Down
1 change: 1 addition & 0 deletions x-pack/auditbeat/tests/system/test_metricsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def test_metricset_login(self):
# Metricset is beta and that generates a warning, TODO: remove later
self.check_metricset("system", "login", COMMON_FIELDS + fields, config, warnings_allowed=True)

@unittest.skip("1/20 build fails https://github.com/elastic/beats/issues/21308")
@unittest.skipIf(sys.platform == "win32", "Not implemented for Windows")
kuisathaverat marked this conversation as resolved.
Show resolved Hide resolved
@unittest.skipIf(sys.platform.startswith('linux') and not (os.path.isdir("/var/lib/dpkg") or os.path.isdir("/var/lib/rpm")),
"Only implemented for dpkg and rpm")
Expand Down