Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick to 7.9: fix: mark flaky tests (#21300) #22008

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Cherry-pick to 7.9: fix: mark flaky tests (#21300) #22008

merged 3 commits into from
Oct 20, 2020

Conversation

kuisathaverat
Copy link
Contributor

Backports the following commits to 7.9:

@kuisathaverat
fix: mark flaky tests (elastic#21300)
8c7bc5c 
* fix: mark flaky test

* Apply suggestions from code review

* Update libbeat/outputs/elasticsearch/client_integration_test.go

* Apply suggestions from code review

* Apply suggestions from code review
@kuisathaverat kuisathaverat requested a review from a team as a code owner October 20, 2020 08:07
@kuisathaverat kuisathaverat self-assigned this Oct 20, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 20, 2020
@kuisathaverat kuisathaverat requested review from jsoriano and a team October 20, 2020 08:09
@kuisathaverat kuisathaverat added automation Team:Automation Label for the Observability productivity team labels Oct 20, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 20, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 20, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22008 updated]

  • Start Time: 2020-10-20T15:25:00.271+0000

  • Duration: 54 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 2753
Skipped 370
Total 3123

@kuisathaverat
Copy link
Contributor Author

this branch seems do not have pytest configured

@kuisathaverat
Copy link
Contributor Author

@jsoriano I'll remove the pytest stuff, because this branch does not use pytest

@jsoriano
Copy link
Member

@jsoriano I'll remove the pytest stuff, because this branch does not use pytest

@kuisathaverat could you please still skip these tests?

jsoriano
jsoriano approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kuisathaverat kuisathaverat merged commit 972b507 into elastic:7.9 Oct 20, 2020
@kuisathaverat kuisathaverat deleted the backport/7.9/pr-21300 branch December 24, 2020 11:06
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kuisathaverat
Cherry-pick to 7.9: fix: mark flaky tests (elastic#21300) (elastic#22008
19dad39 
)

* fix: mark flaky tests (elastic#21300)

* fix: mark flaky test

* Apply suggestions from code review

* Update libbeat/outputs/elasticsearch/client_integration_test.go

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* fix: skip python tests too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@cachedout cachedout cachedout approved these changes

Assignees

@kuisathaverat kuisathaverat

Labels
automation backport Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kuisathaverat @elasticmachine @jsoriano @cachedout