Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19069 to 7.7: [Filebeat][HTTPJson Input]fixes issues with mapstring against JSONObject config #19075

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 9, 2020

Cherry-pick of PR #19069 to 7.7 branch. Original message:

What does this PR do?

This change resolves an error when using "json_objects_array" configuration option. Currently the feature does not work due to mm always being nil

Why is it important?

Fixes a currently unusable feature

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…ect config (elastic#19069)

* fixes issues with mapstring against JSONobject, mm is always nil

* added test for array response working

(cherry picked from commit 6d91d9f)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2020
@marc-gr marc-gr merged commit 9418e50 into elastic:7.7 Jun 10, 2020
@marc-gr marc-gr deleted the backport_19069_7.7 branch June 10, 2020 07:18
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ect config (elastic#19069) (elastic#19075)

* fixes issues with mapstring against JSONobject, mm is always nil

* added test for array response working

(cherry picked from commit d1db38e)

Co-authored-by: Marius Iversen <pillus@chasenet.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants