[Filebeat][HTTPJson Input]fixes issues with mapstring against JSONObject config #19069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
|
Would be possible to add a small test for it? Other than that LGTM 👍 |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Done, ran all tests which passed, the new test would look like this, also tested with modifying it to fail, which it also did if it was incorrect: |
|
Relates: #18919 (comment) This will partially address my reported issue (pagination is still a problem for the scroll example). |
marc-gr
approved these changes
Jun 9, 2020
marc-gr
pushed a commit
to marc-gr/beats
that referenced
this pull request
Jun 9, 2020
…ect config (elastic#19069) * fixes issues with mapstring against JSONobject, mm is always nil * added test for array response working (cherry picked from commit 6d91d9f)
5 tasks
marc-gr
pushed a commit
to marc-gr/beats
that referenced
this pull request
Jun 9, 2020
…ect config (elastic#19069) * fixes issues with mapstring against JSONobject, mm is always nil * added test for array response working (cherry picked from commit 6d91d9f)
5 tasks
marc-gr
pushed a commit
to marc-gr/beats
that referenced
this pull request
Jun 9, 2020
…ect config (elastic#19069) * fixes issues with mapstring against JSONobject, mm is always nil * added test for array response working (cherry picked from commit 6d91d9f)
5 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…ect config (elastic#19069) * fixes issues with mapstring against JSONobject, mm is always nil * added test for array response working
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ect config (elastic#19069) (elastic#19075) * fixes issues with mapstring against JSONobject, mm is always nil * added test for array response working (cherry picked from commit d1db38e) Co-authored-by: Marius Iversen <pillus@chasenet.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change resolves an error when using "json_objects_array" configuration option. Currently the feature does not work due to mm always being nil
Why is it important?
Fixes a currently unusable feature
Checklist
- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.