-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Testing over Agent collection of Agent & Endpoint log files #22549
Comments
Pinging @elastic/ingest-management (Team:Ingest Management) |
@rahulgupta-qasource we have a new feature for 7.11 coming in. Please plan on making at least a simple test case for it, and we can mark it as automated if it ends up being covered fully there. |
Hi @EricDavisX, We have created 06 testcases for above feature on endpoint log files location for different OSs. Testcases links are as follows: Query: Could you please confirm if we need to include scenarios for .deb and .rpm packages as well for logs generation at linux machines. Also, we could not validate this due to issue reported on ticket #69006. As, we were unable to deploy 7.11.0-snapshot Kibana build through staging cloud platform. Please let us know if we are missing anything and is required to be covered. |
I have posted the work-around to get 7.11 cloud working, but this can be tested on 8.0 as well (as most features can be as they are merged first to 8.0 / master line, by specific process). I will review the manual test need with Jen later and we can report back and assign specific tests, and confirm more expectations / AC |
I'm tagging this pr here: elastic/kibana#83356
|
@blakerouse as part of the review for this feature, can you cite if you think the code paths or log paths are different enough that we need to test on different install types (macOS, Linux Tarball, Linux RPM, Windows)? If so, we can do it manually and can automate some in the e2e-testing repo, for us to work. Thanks for the input. |
@EricDavisX Yes the log path is unique per OS. So it should be ensured that it works on all. |
Hi @EricDavisX Thanks for the update. https://elastic.testrail.io/index.php?/cases/view/35088 Please let us know if we are missing anything and is required to be covered. |
Hi @EricDavisX, nothing much from my end. |
We don't use a Fleet API for this. The logs component used for this is written by the Logs & Metrics UI team and uses its own API. I'm not sure what coverage they have for their component. We also populate query suggestions and filter options (dataset and log level) from data plugin's API (a core Kibana plugin). IMO it's out of scope for us to test other plugins' APIs.
There are no API or unit tests for reasons above. Similar to what we discussed yesterday, UI tests would be best to test this kind of feature to make sure all the pieces work together but we don't have that framework set up yet for Fleet.. |
Thank you - I agree it is beyond our need to test the Logs api, this is the benefit of component re-use. We can review the FunctionalUI test framework separately, it may not be hard to set that up for Fleet team if we wanted to make use of what Kibana team has in place already. I'll update the above AC notes. |
Hi again @EricDavisX , regarding this AC:
Due to current limitations with the logs component, updating the log entries in real time is a poor UX right now (a loading screen takes over, and user loses their scroll position). I added this to my PR description:
|
@dikshachauhan-qasource @rahulgupta-qasource hi - I think we have pretty good AC and test requirements cited now, please do update the tests we've started based on the latest you see in the description AC. Hopefully it will be merged and available in an 8.0 snapshot a few days or so. |
Hi @EricDavisX Thanks for the update. We have created 09 testcases for as per new AC update in #22549 for covering Agent logs with a new UI. Testcases links are as follows: Testcases added under Integrate with endpoint Testcases added under section Activity logs However, we have 03 queries and are as follows: Query 1.
Query 2.
Query 3.
Please let us know if we are missing anything. |
Hi - my reply on testing queries: Query 2. Query 3. |
Hi @EricDavisX Thanks for the feedback. We will update testcases for queries as follows: |
Hi - note the minor refinement in the query bar for this feature: elastic/kibana#84108
|
The initial check-in is exciting to review - I am using 8.0 and have noticed / discussed a few items that are being reviewed.
Still will be interesting to see what else will come with it. |
Hi @EricDavisX Thanks for the update. We are performed testing on validating agent logs collection in kibana under Agent and Endpoint logs collection in Kibana Test Run on 7.11.0-SNAPSHOT Kibana cloud build. Build details are as follows:
Also, we have updated 08 testcases and created a new test case: https://elastic.testrail.io/index.php?/cases/view/35132
Further, we will create/update testcases once new pr is available as mentioned in above comment. However, we faced a issue while working upon rpm and deb agents so they remain untested for this feature. Issue is logged as: #22744 |
@rahulgupta-qasource @dikshachauhan-qasource Can you transfer this to a new issue please? And while researching, I think we still have an RPM / Deb relating issue logged, you can make additional notes there. |
@dikshachauhan-qasource as you can see above, I logged the issue for us and have edited its citation in your post for clarity. We will hopefully have a fix to allow us to continue testing... but I doubt it will be for a week perhaps due to vacation and priority. For now, and until fixed, I would continue testing around all things .deb/.rpm in 7.11 / 8.0 as possible. |
Hi @EricDavisX We have created a new testcase as per the update available comment linked to ticket: #83449 summary. Testcase link is as follows: https://elastic.testrail.io/index.php?/cases/view/35182 Please let us know if anything else is required. |
Hi @EricDavisX We have executed 22 testcases under test plan Collection of Agent & Endpoint log files Test Run Build details are as follows:
Please let us know if anything is required from our side. Thanks |
Hi @EricDavisX We have performed exploratory testing today around this feature on 7.11 BC7 and found it working fine. Hence, closing this out. Build details are as follows:
Thanks |
This will be the test ticket to track remaining items for
[Elastic Agent] Allow the agent to collect and send the log of endpoint.
screenshot:
Questions / tasks / to-do:
@jen-huang do we have any of the above covered in API / unit tests so far? Whichever parts we intend to cover but are not done yet can we log a separate issue for it please?
@blakerouse do we have any of the above covered in API & e2e / unit tests so far? Whichever parts we intend to cover but are not done yet can we log a separate issue for it please?
@gogochan I saw you assessed the Endpoint side support, was there anything more we should coordinate on testing (beyond the above)?
The text was updated successfully, but these errors were encountered: