Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Filtering Log level display order can be organized better in Agent Details Fleet UI #84143

Closed
EricDavisX opened this issue Nov 23, 2020 · 6 comments
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@EricDavisX
Copy link
Contributor

From this new in 8.0 feauture:
#81872 (comment)

we are exposing the log level as a drop down. It is current alphabetical, but would it make more sense to present it in ascending verbosity as relating to the log level chosen?

Will discuss with Jen H and see

Screenshots (if relevant):
current:
filter-level

design for the 'setting agent log level' pr:
set-level

Any additional context:
found while reviewing the test ticket, I should have caught the question sooner, sorry - anytime we have a 'list' of things (even a simple list of 4) we should ask what the order is and why it was chosen - elastic/beats#22549

@EricDavisX EricDavisX added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@EricDavisX
Copy link
Contributor Author

if we want to get any more feedback / opinion before changing, that is ok by me. @hbharding @ph @nchaulet input?

@EricDavisX
Copy link
Contributor Author

Note, too: that the list is initially dynamic, to only show log levels that existed in the data, but we are moving that to a fixed list of the same order: levels presented from the top down in increasing verbosity 'error, warning, info, debug'

@nchaulet nchaulet self-assigned this Nov 23, 2020
@jen-huang jen-huang removed their assignment Nov 23, 2020
@EricDavisX
Copy link
Contributor Author

posting note from slack: since we could have more / different levels reporting in, we decided to add the dynamic part back ordered in terms of log verbosity (so we go with the 4 fixed levels) and add any (distinct, after de-duping) dynamic levels after that

@EricDavisX EricDavisX changed the title [Fleet] Filtering Log level to display in Kibana Fleet UI for Agent Details [Fleet] Filtering Log level display order can be organized better in Agent Details Fleet UI Nov 23, 2020
@ph
Copy link
Contributor

ph commented Dec 1, 2020

@EricDavisX SGTM make sense.

@nchaulet
Copy link
Member

nchaulet commented Jan 4, 2021

Should be fixed by #84277

@nchaulet nchaulet closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

5 participants