Merge repo fixes from dev into master #321
Conversation
…dRecaptchaErrors fix: Return error message for unexpected recaptcha errors
…te. (#319) This is a large change meant to restore the repo to a functioning state. The GitHub library was reworked to use the lastest version of the GitHub API module and changes were made to support authentication as a GitHub application. Instructions for creating a private instance hosted on the free tier of Heroku have been added and all references to the public instance have been removed. Heroku hosting is intended to provide users with a more reliable alternative to the public instance, which we will be dropping support for.
|
It's expected that the Travis builds are still failing, right? |
|
@eduardoboucas yeah, there's still 20 failing test cases but I've been able to manually test GitHub integration both with basic token access and with app auth. In both instances it was able to successfully make a PR on my test repo with my comment. I plan to look into fixing those failing test cases next l, so we could wait for that work to be finished before merging into master, but then master will stay broken for a longer period of time. |
|
@alexwaibel I'm happy for this to be merged into master now, if that's what you want to do. 🙂 |
|
@eduardoboucas sounds good, I'll go ahead and merge this in. When I get more time I plan to fix those remaining test failures so we can get travis builds back to a passing state. |
I've just merged #319 into the dev branch and think it would be wise to also merge these fixes into master so that others can more easily begin hosting their own instances.