Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return error message for unexpected recaptcha errors #308

Merged
merged 1 commit into from
Dec 7, 2019
Merged

fix: Return error message for unexpected recaptcha errors #308

merged 1 commit into from
Dec 7, 2019

Conversation

deadlydog
Copy link
Contributor

PR to help address issue #108 by returning an error message for unexpected ReCaptcha errors.

@deadlydog
Copy link
Contributor Author

Hey @eduardoboucas @VincentTam @alexwaibel just pinging you on this one, as I feel it's a super low-risk PR that could be merged in to to give additional info for a generic error that leads to quite a few issue reports. Not sure which of you has the power to approve and merge it. Thanks!

@alexwaibel alexwaibel self-assigned this Dec 7, 2019
Copy link
Collaborator

@alexwaibel alexwaibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved. Thank you for your contribution!

@alexwaibel alexwaibel merged commit 6129707 into eduardoboucas:dev Dec 7, 2019
@deadlydog deadlydog deleted the ReturnErrorMessageForUnexpectedRecaptchaErrors branch November 4, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants