Revert "Add support for GitHub Apps" #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d800786.
This was referenced Apr 19, 2019
This was referenced Jun 25, 2019
This was referenced Jul 3, 2019
|
I was able to get the app running on the latest from master by adding back v3 as an option for legacy auth. Not sure why it was suddenly removed for v3. See Jimeh87@392a83d for the change I made. The only other issue I was running into was when I added a new comment, github was throwing a 404 error. Turns out the bot user needs the repo -> public_repo scope enabled as well as the admin:repo_hook read and write hooks. 🤷♂ |
|
I decided to work to fix the current repo rather than rolling back these commits. This PR was useful to see at what point thing started breaking in the repo so thank you for this contribution even though I will not be merging in this PR. |
caiopavanelli
pushed a commit
to caiopavanelli/staticman
that referenced
this pull request
Aug 17, 2020
Instructions for Multilingual added on README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d800786.
Master is currently broken. By reverting back the GithubApp API version 3 changes from the dev branch unit tests will pass again and support for version 2 API will be restored.