-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix line-break formatting in pull requests #90
Comments
I can confirm this. But it can be solved easily, when generating a table: Lines 201 to 203 in ecf0386
Just remove new lines and replace them with breaks Object.keys(fields).forEach(field => {
table.push([field, fields[field].replace(/\n/gm, '<br />')])
}) Afaik this is the only way to add newlines to a markdown table.
|
Bump, any news on this one? |
Just got two comments with the same issue, and each of them renders differently. One looks exactly same like the PR in @klundberg 's repo. And the other look like this: Furthermore, I don't understand where the fields |
@JokerQyou The code is only replacing LF, but I suspect your example had CR/LF. In PR #289 I chained two calls to replace to handle both scenarios. |
@BloggerBust-bot Your PR contains an unnecessary dependence on #285, so I created another one for the convenience of v3 users. Anyways, great work! |
I just got this PR from staticman: klundberg/klundberg.com#4
The text was updated successfully, but these errors were encountered: