Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifications): Update Subscription DTO to adopt common Address #549

Merged
merged 3 commits into from
Mar 17, 2021
Merged

feat(notifications): Update Subscription DTO to adopt common Address #549

merged 3 commits into from
Mar 17, 2021

Commits on Mar 16, 2021

  1. feat(notifications): Update Subscription DTO to adopt common Address 

    - Add type EMAIL to the "oneof" validation of Address DTO
- Replace Channel DTO with Address DTO
- Replace Channel model with Address model

Signed-off-by: Felix Ting <felix@iotechsys.com>
    @FelixTing
    FelixTing committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    50867e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. fix(notifications): Modify inappropriate variable names 

    Signed-off-by: Felix Ting <felix@iotechsys.com>
    @FelixTing
    FelixTing committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    99ccf6c View commit details
    Browse the repository at this point in the history

  2. fix(notification): Add channel type check to Validate method 

    Signed-off-by: Felix Ting <felix@iotechsys.com>
    @FelixTing
    FelixTing committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    3e070a1 View commit details
    Browse the repository at this point in the history