feat(notifications): Update Subscription DTO to adopt common Address #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type EMAIL to the "oneof" validation of Address DTO - Replace Channel DTO with Address DTO - Replace Channel model with Address model Signed-off-by: Felix Ting <felix@iotechsys.com>
lenny-goodell
requested changes
Mar 16, 2021
v2/dtos/address.go
Outdated
| @@ -144,3 +152,19 @@ func FromAddressModelToDTO(address models.Address) Address { | |||
| } | |||
| return dto | |||
| } | |||
|
|
|||
| func ToAddressModels(channelDTOs []Address) []models.Address { | |||
| channelModels := make([]models.Address, len(channelDTOs)) | |||
There was a problem hiding this comment.
Why channelModels and channelModels when this is Addresses? how about just dtos & models
There was a problem hiding this comment.
It's a copy-paste mistake. Modified. 99ccf6c
| return errors.NewCommonEdgeXWrapper(err) | ||
| } | ||
| for _, c := range request.Subscription.Channels { | ||
| err = c.Validate() |
There was a problem hiding this comment.
When using Address DTO for Channels are MQTT is not a valid type of channel for subscriptions? Will this validation fail appropriately when MQTT is the type? i.e. something like MQTT is not valid type for Channel.
There was a problem hiding this comment.
Good catch. Thanks! Channel type check has been added. 3e070a1
Signed-off-by: Felix Ting <felix@iotechsys.com>
Signed-off-by: Felix Ting <felix@iotechsys.com>
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: #545
What is the new behavior?
Subscription Channel is of type Address.
Close #545
Does this PR introduce a breaking change?
New Imports