fix: Check empty value when converting Model to UpdateDTO #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Check the empty value when convert Model to DTO
- FromProvisionWatcherModelToUpdateDTO
- FromDeviceModelToUpdateDTO
- FromDeviceServiceModelToUpdateDTO
2. API client lib handle the 404 StatusNotFound response
3. Modify BinaryReading validate annotation
Fix edgexfoundry#528
Signed-off-by: weichou <weichou1229@gmail.com>
6 tasks
cloudxxx8
requested changes
Mar 2, 2021
Fix edgexfoundry#528 Signed-off-by: weichou <weichou1229@gmail.com>
|
recheck |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #528
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: #528
What is the new behavior?
Check the empty value when convert Model to UpdateDTO
API client lib handle the 404 StatusNotFound response
Modify BinaryReading validate annotation
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information