Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] Check empty value when converting Model to UpdateDTO #528

Closed
weichou1229 opened this issue Mar 2, 2021 · 0 comments · Fixed by #529
Closed

[V2] Check empty value when converting Model to UpdateDTO #528

weichou1229 opened this issue Mar 2, 2021 · 0 comments · Fixed by #529

Comments

@weichou1229
Copy link
Member

weichou1229 commented Mar 2, 2021 •
edited
Loading

  1. Check the empty value when convert Model to UpdateDTO

    • FromProvisionWatcherModelToUpdateDTO
    • FromDeviceModelToUpdateDTO
    • FromDeviceServiceModelToUpdateDTO

  2. API client lib handle the 404 StatusNotFound response

  3. Modify BinaryReading validate annotation
@weichou1229 weichou1229 changed the title [V2] Check empty value when converting Model to DTO [V2] Check empty value when converting Model to UpdateDTO Mar 2, 2021
weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Mar 2, 2021
@weichou1229
fix: Check empty value when converting Model to UpdateDTO
9b4d207 
1. Check the empty value when convert Model to UpdateDTO
      - FromProvisionWatcherModelToUpdateDTO
      - FromDeviceModelToUpdateDTO
      - FromDeviceServiceModelToUpdateDTO

2. API client lib handle the 404 StatusNotFound response
3. Modify BinaryReading validate annotation

Fix edgexfoundry#528

Signed-off-by: weichou <weichou1229@gmail.com>
weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Mar 2, 2021
@weichou1229
fix: Check empty value when converting Model to DTO
6808a19 
1. Check the empty value when convert Model to DTO
      - FromProvisionWatcherModelToUpdateDTO
      - FromDeviceModelToUpdateDTO
      - FromDeviceServiceModelToUpdateDTO

2. API client lib handle the 404 StatusNotFound response
3. Modify BinaryReading validate annotation

Fix edgexfoundry#528
@weichou1229 weichou1229 mentioned this issue Mar 2, 2021
Merged
6 tasks
weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Mar 2, 2021
@weichou1229
fix: Check empty value when converting Model to DTO
6459cb9 
1. Check the empty value when convert Model to DTO
      - FromProvisionWatcherModelToUpdateDTO
      - FromDeviceModelToUpdateDTO
      - FromDeviceServiceModelToUpdateDTO

2. API client lib handle the 404 StatusNotFound response
3. Modify BinaryReading validate annotation

Fix edgexfoundry#528

Signed-off-by: weichou <weichou1229@gmail.com>
weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Mar 2, 2021
@weichou1229
fix: Modify the client lib error handling
5c57ab8 
Fix edgexfoundry#528

Signed-off-by: weichou <weichou1229@gmail.com>
weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Mar 2, 2021
@weichou1229
fix: Modify the client lib error handling
034c2e8 
Fix edgexfoundry#528

Signed-off-by: weichou <weichou1229@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Check empty value when converting Model to UpdateDTO weichou1229/go-mod-core-contracts
1 participant
@weichou1229