Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add integration test for app-service with external-mqtt-trigger #534

Merged
merged 1 commit into from
Oct 21, 2021
Merged

feat: Add integration test for app-service with external-mqtt-trigger #534

merged 1 commit into from
Oct 21, 2021

Conversation

cherrycl
Copy link
Contributor

Fix #514
Signed-off-by: Cherry Wang cherry@iotechsys.com

@cherrycl
feat: Add integration test for app-service with external-mqtt-trigger
a36d776 
Signed-off-by: Cherry Wang <cherry@iotechsys.com>
@cherrycl
Copy link
Contributor Author

Pending for edgexfoundry/edgex-compose PR #195.

lenny-goodell
lenny-goodell approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can see.
As long as the Trigger is responding to subscribed messages, passing them through the pipeline and they get exported properly, I am good. ;-)

jinlinGuan
jinlinGuan approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@jinlinGuan jinlinGuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlinGuan jinlinGuan merged commit e0a3071 into edgexfoundry:main Oct 21, 2021
@cherrycl cherrycl deleted the issue-514 branch November 18, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenny-goodell lenny-goodell lenny-goodell approved these changes

@jinlinGuan jinlinGuan jinlinGuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add App Services integration tests for External MQTT Trigger
3 participants
@cherrycl @lenny-goodell @jinlinGuan