feat: Add new app-service: app-service-external-mqtt-trigger for TAF test #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for edgexfoundry/app-service-configurable PR #338 merged. |
lenny-goodell
requested changes
Oct 19, 2021
Comment on lines
19
to
24
| EDGEX_PROFILE=external-mqtt-trigger | ||
| TRIGGER_EXTERNALMQTT_URL=tcp://MQTT_BROKER_ADDRESS_PLACE_HOLDER:1883 | ||
| WRITABLE_PIPELINE_FUNCTIONS_MQTTEXPORT_PARAMETERS_BROKERADDRESS=tcp://MQTT_BROKER_ADDRESS_PLACE_HOLDER:1883 | ||
| WRITABLE_PIPELINE_FUNCTIONS_MQTTEXPORT_PARAMETERS_TOPIC=edgex-export | ||
| # allows scripts to find and change with sed | ||
| WRITABLE_LOGLEVEL=INFO |
There was a problem hiding this comment.
Looks like the settings are only use in the one yaml file, so we could reduce number of files by moving these into the environment section of the yaml file.
There was a problem hiding this comment.
Moved the environment variables to the compose-builder/add-asc-external-mqtt-trigger.yml file.
…test Signed-off-by: Cherry Wang <cherry@iotechsys.com>
cherrycl
force-pushed
the
add-new-app-service
branch
from
811007c
to
41d885a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new app-service: app-service-external-mqtt-trigger for edgexfoundry/edgex-taf issue #514.
Signed-off-by: Cherry Wang cherry@iotechsys.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions