Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove system management agent and executor #4265

Merged
merged 2 commits into from
Jan 6, 2023
Merged

refactor!: Remove system management agent and executor #4265

merged 2 commits into from
Jan 6, 2023

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Jan 5, 2023

BREAKING CHANGE: SMA is deprecated in EdgeX 3.0

Signed-off-by: Bryon Nevis bryon.nevis@intel.com

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

(Going to rely on the build smoke tests for this)

BREAKING CHANGE: SMA is deprecated in EdgeX 3.0

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #4265 (19dda05) into main (c6d570f) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4265      +/-   ##
==========================================
- Coverage   43.29%   42.93%   -0.36%     
==========================================
  Files         125      119       -6     
  Lines       11126    10888     -238     
==========================================
- Hits         4817     4675     -142     
+ Misses       5896     5801      -95     
+ Partials      413      412       -1     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@bnevis-i
Copy link
Collaborator Author

bnevis-i commented Jan 6, 2023

Here goes. Cross your fingers.

@bnevis-i bnevis-i merged commit 91e411a into edgexfoundry:main Jan 6, 2023
@bnevis-i bnevis-i deleted the remove-sma branch January 6, 2023 16:18
@cloudxxx8 cloudxxx8 mentioned this pull request Jan 8, 2023
@fantacymaker
Copy link

Why should this be removed?

@fantacymaker
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants