refactor!: Remove system management agent and executor (#4265)

* refactor!: Remove system management agent and executor

BREAKING CHANGE: SMA is deprecated in EdgeX 3.0

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>

* refactor(snap)!: Remove obsolete sma references and wrapper script

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Co-authored-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>

.gitignore

@@ -22,8 +22,6 @@ cmd/security-secretstore-setup/security-secretstore-setup
 cmd/support-logging/support-logging
 cmd/support-notifications/support-notifications
 cmd/support-scheduler/support-scheduler
-cmd/sys-mgmt-agent/sys-mgmt-agent
-cmd/sys-mgmt-executor/sys-mgmt-executor
 cmd/secrets-config/secrets-config
 cmd/security-bootstrapper/security-bootstrapper
 cmd/security-spiffe-token-provider/security-spiffe-token-provider

Makefile

@@ -19,7 +19,6 @@ DOCKERS= \
 	docker_core_metadata \
 	docker_core_command  \
 	docker_support_notifications \
-	docker_sys_mgmt_agent \
 	docker_support_scheduler \
 	docker_security_proxy_setup \
 	docker_security_secretstore_setup \
@@ -36,8 +35,6 @@ MICROSERVICES= \
 	cmd/core-metadata/core-metadata \
 	cmd/core-command/core-command \
 	cmd/support-notifications/support-notifications \
-	cmd/sys-mgmt-executor/sys-mgmt-executor \
-	cmd/sys-mgmt-agent/sys-mgmt-agent \
 	cmd/support-scheduler/support-scheduler \
 	cmd/security-proxy-setup/security-proxy-setup \
 	cmd/security-secretstore-setup/security-secretstore-setup \
@@ -109,12 +106,6 @@ scheduler: cmd/support-scheduler/support-scheduler
 cmd/support-scheduler/support-scheduler:
 	$(GO) build -tags "$(ADD_BUILD_TAGS) $(NON_DELAYED_START_GO_BUILD_TAG_FOR_SUPPORT)" $(GOFLAGS) -o $@ ./cmd/support-scheduler
 
-cmd/sys-mgmt-executor/sys-mgmt-executor:
-	$(GO) build -tags "$(NO_MESSAGEBUS_GO_BUILD_TAG) $(NON_DELAYED_START_GO_BUILD_TAG_FOR_CORE)" $(GOFLAGS) -o $@ ./cmd/sys-mgmt-executor
-
-cmd/sys-mgmt-agent/sys-mgmt-agent:
-	$(GO) build -tags "$(NO_MESSAGEBUS_GO_BUILD_TAG) $(NON_DELAYED_START_GO_BUILD_TAG_FOR_CORE)" $(GOFLAGS) -o $@ ./cmd/sys-mgmt-agent
-
 proxy: cmd/security-proxy-setup/security-proxy-setup
 cmd/security-proxy-setup/security-proxy-setup:
 	$(GO) build -tags "$(NO_MESSAGEBUS_GO_BUILD_TAG) $(NON_DELAYED_START_GO_BUILD_TAG_FOR_CORE)" $(GOFLAGS) -o ./cmd/security-proxy-setup/security-proxy-setup ./cmd/security-proxy-setup
@@ -248,17 +239,6 @@ docker_support_scheduler: docker_base
 		-t edgexfoundry/support-scheduler:$(DOCKER_TAG) \
 		.
 
-docker_sys_mgmt_agent: docker_base
-	docker build \
-		--build-arg http_proxy \
-		--build-arg https_proxy \
-		--build-arg BUILDER_BASE=$(LOCAL_CACHE_IMAGE) \
-		-f cmd/sys-mgmt-agent/Dockerfile \
-		--label "git_sha=$(GIT_SHA)" \
-		-t edgexfoundry/sys-mgmt-agent:$(GIT_SHA) \
-		-t edgexfoundry/sys-mgmt-agent:$(DOCKER_TAG) \
-		.
-
 dproxy: docker_security_proxy_setup
 docker_security_proxy_setup: docker_base
 	docker build \

cmd/security-bootstrapper/res/configuration.toml

@@ -47,8 +47,6 @@ LogLevel = "INFO"
           Description = "role for notifications"
         [StageGate.Registry.ACL.Roles.support-scheduler]
           Description = "role for scheduler"
-        [StageGate.Registry.ACL.Roles.sys-mgmt-agent]
-          Description = "role for system management agent"
         [StageGate.Registry.ACL.Roles.device-virtual]
           Description = "role for device virtual service"
         [StageGate.Registry.ACL.Roles.device-rest]

cmd/security-file-token-provider/res/token-config.json

@@ -26,9 +26,6 @@
   "device-rest": {
     "edgex_use_defaults": true
   },
-  "sys-mgmt-agent": {
-    "edgex_use_defaults": true
-  },
   "support-scheduler": {
     "edgex_use_defaults": true
   },

cmd/security-proxy-setup/res/configuration.toml

@@ -98,12 +98,6 @@ ServerName = ""
   Host = "localhost"
   Port = 59861
 
-  [Routes.sys-mgmt-agent]
-  Name = "sys-mgmt-agent"
-  Protocol = "http"
-  Host = "localhost"
-  Port = 58890
-
   [Routes.rules-engine]
   Name = "rules-engine"
   Protocol = "http"

go.mod

@@ -6,7 +6,6 @@ require (
 	github.com/edgexfoundry/go-mod-bootstrap/v3 v3.0.0-dev.5
 	github.com/edgexfoundry/go-mod-core-contracts/v3 v3.0.0-dev.2
 	github.com/edgexfoundry/go-mod-messaging/v3 v3.0.0-dev.2
-	github.com/edgexfoundry/go-mod-registry/v3 v3.0.0-dev.3
 	github.com/edgexfoundry/go-mod-secrets/v3 v3.0.0-dev.1
 	github.com/fxamacker/cbor/v2 v2.4.0
 	github.com/golang-jwt/jwt/v4 v4.4.3
@@ -29,6 +28,7 @@ require (
 	github.com/cenkalti/backoff v2.2.1+incompatible // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/edgexfoundry/go-mod-configuration/v3 v3.0.0-dev.2 // indirect
+	github.com/edgexfoundry/go-mod-registry/v3 v3.0.0-dev.3 // indirect
 	github.com/fatih/color v1.9.0 // indirect
 	github.com/go-kit/log v0.2.1 // indirect
 	github.com/go-logfmt/logfmt v0.5.1 // indirect