Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device name, profile name, resource name, and command name supports Chinese naming #4053

Closed
watjt opened this issue Jun 15, 2022 · 6 comments · Fixed by #4664
Closed

Device name, profile name, resource name, and command name supports Chinese naming #4053

watjt opened this issue Jun 15, 2022 · 6 comments · Fixed by #4664
Assignees
@weichou1229
Labels
enhancement New feature or request

Comments

@watjt
Copy link

watjt commented Jun 15, 2022

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for...

ui-go , core-data, core-metadata, core-command and all device service, those components used package go-mod-core-contracts

Description [REQUIRED]

A clear and concise description of the problem or missing capability...

Edgex is used in many traditional industries in China, and many PLC or other device names and addresses are named in Chinese.

Describe the solution you'd like

If you have a solution in mind, please describe it.

Modify name regular check in go-mod-core-contracts, and use url.queryUnescape decode those Chinese name in core-metadata, ui-go etc.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@watjt watjt added the enhancement New feature or request label Jun 15, 2022
@watjt watjt changed the title Chinese naming is supported for device names, profile names, resource names, and command names Device names, profile names, resource names, and command names supports Chinese naming Jun 15, 2022
@watjt watjt changed the title Device names, profile names, resource names, and command names supports Chinese naming Device name, profile name, resource name, and command name supports Chinese naming Jun 15, 2022
@jpwhitemn
Copy link
Member

This issue is closely related to this one #3935 . At the May 2022 planning meeting, we discussed this need. We left it in the backlog but decided not to address this in this release (Levski). Reconsider in future planning meetings given multiple needs now.

@cloudxxx8
Copy link
Member

Maybe we can just allow % char to name for now. Users can leverage URL escape mechanism to accomplish some sort of globalization

@lenny-goodell
Copy link
Member

Maybe our validator needs to be reversed to not allow specific characters (space, comma, etc.) rather than restrict to limited set of characters. This should allow Chinese characters??

@cloudxxx8
Copy link
Member

yes, we can discuss in the next Core WG meeting

@cloudxxx8 cloudxxx8 mentioned this issue Jul 13, 2022
Closed
@weichou1229 weichou1229 mentioned this issue Feb 20, 2023
Closed
@cloudxxx8
Copy link
Member

we have implemented it for the resource / command name, and we can apply this mechanism to allow Chinese in other name fields in v3.1

@jumpingliu jumpingliu assigned weichou1229 and unassigned jackchenjc Aug 18, 2023
This was referenced Aug 22, 2023
Closed
Closed
weichou1229 added a commit to weichou1229/edgex-go that referenced this issue Aug 25, 2023
@weichou1229
feat: Accept Url escape in API path
15e2ac1 
Use escaped for message bus topic
- service name
- profile name
- device name

Close edgexfoundry#4053

Signed-off-by: bruce <weichou1229@gmail.com>
@weichou1229 weichou1229 mentioned this issue Aug 25, 2023
Merged
5 tasks
@weichou1229
Copy link
Member

Opened PRs for this issue,

weichou1229 added a commit to weichou1229/edgex-go that referenced this issue Sep 4, 2023
@weichou1229
feat: Accept Url escape in API path
67d489b 
Use escaped for message bus topic
- service name
- profile name
- device name

Close edgexfoundry#4053

Signed-off-by: bruce <weichou1229@gmail.com>
@weichou1229 weichou1229 mentioned this issue Sep 6, 2023
Closed
@cherrycl cherrycl mentioned this issue Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weichou1229 weichou1229

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Accept Url escape in API path weichou1229/edgex-go
7 participants
@jpwhitemn @weichou1229 @cloudxxx8 @lindseysimple @watjt @jackchenjc @lenny-goodell