Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Accept Url escape in API path #1502

Merged
merged 1 commit into from
Sep 5, 2023
Merged

feat: Accept Url escape in API path #1502

merged 1 commit into from
Sep 5, 2023

Conversation

weichou1229
Copy link
Member

Use escaped for message bus topic

  • service name
  • profile name
  • device name

Close #1495

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) not impact

Testing Instructions

Run core service and device service to test the API.

New Dependency Instructions (If applicable)

@weichou1229
feat: Accept Url escape in API path
fdbdbc1 
Use escaped for message bus topic
- service name
- profile name
- device name

Close edgexfoundry#1495

Signed-off-by: bruce <weichou1229@gmail.com>
@weichou1229 weichou1229 mentioned this pull request Aug 25, 2023
Closed
cloudxxx8
cloudxxx8 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit a3c9196 into edgexfoundry:main Sep 5, 2023
2 checks passed
@cherrycl cherrycl mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudxxx8 cloudxxx8 cloudxxx8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Accept Url escape in API path
2 participants
@weichou1229 @cloudxxx8