Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs build error #1347

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

jumpingliu
Copy link
Contributor

@jumpingliu jumpingliu commented Mar 5, 2024

fix #1337

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

@jumpingliu jumpingliu force-pushed the fix-build-error branch 4 times, most recently from e303558 to 30e8fed Compare March 5, 2024 07:41
@jumpingliu jumpingliu marked this pull request as draft March 5, 2024 07:50
@jumpingliu jumpingliu force-pushed the fix-build-error branch 10 times, most recently from 3eb1aad to 189ced3 Compare March 8, 2024 07:40
Signed-off-by: Melody <melody@iotechsys.com>
@jumpingliu jumpingliu marked this pull request as ready for review March 8, 2024 07:45
@jumpingliu jumpingliu requested review from cloudxxx8 and lenny-goodell and removed request for cloudxxx8 March 8, 2024 08:00
@jumpingliu
Copy link
Contributor Author

Hi @lenny-intel, there're lots of broken links on device sdk and app service, and also lots of valid links return with 403 http response code so I put them into the raise_error_excludes section. Please could you help review to see if those updated links are correct? Thanks

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure you can pass DCO and validation

Signed-off-by: Melody <melody@iotechsys.com>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit e6dae90 into edgexfoundry:main Mar 25, 2024
3 checks passed
edgex-jenkins added a commit that referenced this pull request Mar 25, 2024
Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
@jumpingliu jumpingliu deleted the fix-build-error branch March 25, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants