feat: Update UCR for parent-child to remove some requirements. #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need "main" or "system" devices anymore. It seemed less invasive to prevent deletion of devices with children (similar to how we prevent device profiles from being deleted if there are devices using them), instead of doing a cascading deletion. Also minor formatting changes needed for mkdocs. Signed-off-by: Corey Mutter <CoreyMutter@eaton.com>
lenny-goodell
previously requested changes
Feb 26, 2024
Signed-off-by: Corey Mutter <CoreyMutter@eaton.com>
eaton-coreymutter
force-pushed
the
simplify-parent-ucr
branch
from
ff9fa89
to
51a6fb1
Compare
|
"make build" and "make serve" work locally, I cannot figure out how to fix whatever is going on in the Jenkins build. |
|
@eaton-coreymutter I am asking @jumpingliu to check the Jenkins build issue |
|
recheck |
|
sorry, closed the PR inaccidentally |
cloudxxx8
approved these changes
Mar 25, 2024
edgex-jenkins
added a commit
that referenced
this pull request
Mar 25, 2024
…1337) Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need "main" or "system" devices anymore.
It seemed less invasive to prevent deletion of devices with children (similar to how we prevent device profiles from being deleted if there are devices using them), instead of doing a cascading deletion.
Also minor formatting changes needed for mkdocs.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements: