New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AArch64: Implement BNDCHKwithSpineCHKEvaluator() #10320

Merged

0xdaryl merged 1 commit into eclipse-openj9:master from knn-k:aarch64spineCHK

May 28, 2021

Contributor

knn-k commented Aug 4, 2020

This commit implements BNDCHKwithSpineCHKEvaluator() for AArch64.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

knn-k added comp:jit arch:aarch64 labels

knn-k marked this pull request as draft

August 4, 2020 08:47

Contributor Author

knn-k commented Aug 4, 2020

This PR depends on eclipse/omr#5440 and eclipse/omr#5442.

knn-k mentioned this pull request

Implement support for balanced GC in AArch64 JIT #8034

Closed

knn-k force-pushed the aarch64spineCHK branch from e15da71 to f63d504 Compare

August 18, 2020 23:46

Contributor Author

knn-k commented Aug 18, 2020

jenkins test sanity alinux64 jdk11

Contributor Author

knn-k commented Aug 19, 2020

jenkins test sanity.system alinux64 jdk11

knn-k marked this pull request as ready for review

August 19, 2020 11:54

knn-k changed the title ~~WIP: AArch64: Implement BNDCHKwithSpineCHKEvaluator()~~ AArch64: Implement BNDCHKwithSpineCHKEvaluator()

Contributor Author

knn-k commented Aug 19, 2020

There are two failures in sanity.system. They are known issues with JlmRemote #9046, and not introduced by this PR.

Member

DanHeidinga commented Aug 24, 2020

@0xdaryl Can you review this? It's related to a jdk15 (0.22) release issue. @knn-k can you confirm whether this needs to be in the 0.22 release?

Contributor Author

knn-k commented Aug 25, 2020

It's related to a jdk15 (0.22) release issue.

Is there any issue or test failure with JDK 15 AArch64 that is caused by unimplemented BNDCHKwithSpineCHKEvaluator()?

Member

DanHeidinga commented Aug 25, 2020

It's related to a jdk15 (0.22) release issue.

Is there any issue or test failure with JDK 15 AArch64 that is caused by unimplemented BNDCHKwithSpineCHKEvaluator()?

It was linked from #9046 but reading more closely thru this issue indicates this isn't the fix for that issue:

They are known issues with JlmRemote #9046, and not introduced by this PR.

So it's not needed for the 0.22 release

knn-k force-pushed the aarch64spineCHK branch from f63d504 to 3b844ac Compare

November 7, 2020 10:29

Contributor Author

knn-k commented Nov 7, 2020

Resolved the merge conflict.

Contributor Author

knn-k commented Nov 7, 2020

jenkins test sanity alinux64 jdk11

knn-k requested a review from 0xdaryl

November 8, 2020 10:51

Contributor Author

knn-k commented Dec 7, 2020

@0xdaryl Could you review this PR, please? Thanks.

knn-k force-pushed the aarch64spineCHK branch from 3b844ac to 661c692 Compare

February 4, 2021 01:39

knn-k marked this pull request as draft

February 5, 2021 12:21

knn-k force-pushed the aarch64spineCHK branch from 661c692 to 5c32537 Compare

February 8, 2021 02:56

Contributor Author

knn-k commented Feb 8, 2021

Fixed a bug found in extended.functional (using the test mode settings from adoptium/TKG#97)

knn-k marked this pull request as ready for review

February 8, 2021 03:08

knn-k force-pushed the aarch64spineCHK branch from 5c32537 to 0066b04 Compare

February 8, 2021 23:32

Contributor Author

knn-k commented Feb 8, 2021

Updated the code by removing calls to vm.heapBaseAddress() (See #11688).

knn-k force-pushed the aarch64spineCHK branch from 0066b04 to 27fe678 Compare

April 5, 2021 03:08

Contributor Author

knn-k commented Apr 5, 2021

I updated the code to resolve a merge conflict.

knn-k mentioned this pull request

Enable modes with balanced GC for AArch64 adoptium/TKG#97

Merged

Contributor

0xdaryl commented May 25, 2021

Jenkins test sanity.system alinux64 jdk11

Contributor Author

knn-k commented May 25, 2021

Please wait for #12758 to be merged, so that the sanity.system tests pass.

Contributor Author

knn-k commented May 26, 2021

Jenkins test sanity.system alinux64 jdk11

Contributor

0xdaryl commented May 26, 2021

System test failed with a JLink hash error:

JLNK Error: Hash of java.xml (0cda2bac40a86a8ab5b1f5797ec814fdde552f74f8ee487f0cb81de019dd0912) differs to expected hash (3bc50f598c51e86ab18a95be560cf4e11411fe9d30f381011d0e81aea1c609a4) recorded in java.base

We've seen this before intermittently and don't believe it is an OpenJ9 problem. I'll re-run the testing.

Contributor

0xdaryl commented May 26, 2021

Jenkins test sanity.system alinux64 jdk11

Contributor

0xdaryl commented May 26, 2021

Jenkins test sanity.system alinux64 jdk11

Trying again. Build never got off the ground.

Contributor

0xdaryl commented May 27, 2021

Jenkins test sanity.system alinux64 jdk11

Trying again. Build aborted.

Contributor Author

knn-k commented May 27, 2021

There are some failures with sanity.system in another PR (#12731) today. They look like the known issue related to openssl.

Contributor Author

knn-k commented May 27, 2021

sanity.system is OK.
https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.system_aarch64_linux_Personal/7/

On the other hand, a build job failed with the following exception:
https://openj9-jenkins.osuosl.org/job/Build_JDK11_aarch64_linux_Personal/17/

java.lang.SecurityException: SHA-256 digest error for org/eclipse/jgit/lib/PersonIdent.class
	at sun.security.util.ManifestEntryVerifier.verify(ManifestEntryVerifier.java:239)
	at java.util.jar.JarVerifier.processEntry(JarVerifier.java:243)
	at java.util.jar.JarVerifier.update(JarVerifier.java:230)

Contributor Author

knn-k commented May 27, 2021

Jenkins build alinux64 jdk11

Contributor Author

knn-k commented May 27, 2021

Jenkins compile alinux64 jdk11

3 similar comments

Contributor Author

knn-k commented May 27, 2021

Jenkins compile alinux64 jdk11

Contributor

0xdaryl commented May 27, 2021

Jenkins compile alinux64 jdk11

Contributor

0xdaryl commented May 27, 2021

Jenkins compile alinux64 jdk11

0xdaryl approved these changes

View reviewed changes

0xdaryl self-requested a review

May 27, 2021 20:41

Contributor

0xdaryl commented May 27, 2021

I just realized that most of the testing run in this PR wasn't testing the code paths with -Xgcpolicy:balanced because those tests have been excluded on AArch64.

Shouldn't #10321, or a reversion of #8569, or enabling the disabled test modes be included as part of this PR?


          AArch64: Implement BNDCHKwithSpineCHKEvaluator()

5ff58f3

This commit implements BNDCHKwithSpineCHKEvaluator() for AArch64.
It also enables a test with balanced GC for AArch64, which was disabled
by eclipse-openj9#8569.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>

knn-k force-pushed the aarch64spineCHK branch from 27fe678 to 5ff58f3 Compare

May 27, 2021 23:52

Contributor Author

knn-k commented May 27, 2021

I moved the change in #10321 to this PR.

Contributor Author

knn-k commented May 27, 2021

jenkins test sanity alinux64 jdk11

knn-k mentioned this pull request

WIP: AArch64: Enable a test with balanced GC #10321

Closed

Contributor Author

knn-k commented May 28, 2021

Balanced GC tests in system tests will be enabled by adoptium/TKG#97

Contributor

0xdaryl commented May 28, 2021

Balanced GC tests in system tests will be enabled by adoptium/TKG#97

Thanks.

0xdaryl approved these changes

View reviewed changes

Contributor

0xdaryl commented May 28, 2021

We will enable system tests in the adoptium repo after demonstrating they run successfully.

0xdaryl merged commit 9a70201 into eclipse-openj9:master

knn-k deleted the aarch64spineCHK branch

May 28, 2021 11:28

JasonFengJ9 mentioned this pull request

aarch64_mac system test JLNK Error: Hash of java.xml differs to expected hash recorded in java.base #16311

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch:aarch64 comp:jit